Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve the acquisition of dom logic #48989

Merged
merged 4 commits into from
May 20, 2024
Merged

refactor: improve the acquisition of dom logic #48989

merged 4 commits into from
May 20, 2024

Conversation

Wxh16144
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #48981

📝 Changelog

Language Changelog
🇺🇸 English Improve <Form /> Scroll to find DOM Logic
🇨🇳 Chinese 改进 <Form /> 滑动获取 dom 逻辑

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented May 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited

👁 Visual Regression Report for PR #48989 Passed ✅

🎯 Target branch: master (35015c7)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited

Preview is ready

@socket-security Socket Security
Copy link

socket-security bot commented May 20, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/eslint-plugin-react-hooks@4.6.2

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 20, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 20, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Wxh16144 Wxh16144 marked this pull request as ready for review May 20, 2024 08:13
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (35015c7) to head (8f9bd79).

Additional details and impacted files 
@@            Coverage Diff             @@
##            master    #48989    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          745       745            
  Lines        13252     12976   -276     
  Branches      3513      3402   -111     
==========================================
- Hits         13252     12976   -276

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit baef247 into ant-design:master May 20, 2024
61 checks passed
@zombieJ zombieJ mentioned this pull request May 27, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ zombieJ approved these changes

@kiner-tang kiner-tang kiner-tang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form scrollToFirstError InputNumber 报错
4 participants
@Wxh16144 @afc163 @zombieJ @kiner-tang