-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipes-targets): add lambda function #30271
base: main
Are you sure you want to change the base?
Conversation
23db285
to
3aa03cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. I added some minor improvement ideas.
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.lambda.handler/handler.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.lambda.handler/handler.ts
Outdated
Show resolved
Hide resolved
const app = new App(); | ||
const stack = new Stack(app, 'TestLambdaFunctionStack'); | ||
|
||
const lambdaFunction = new lambda.Function(stack, 'MyLambda', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to define a lambda. A string of an arn should be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? Shouldnt be the lambda be available for import? Because for the LambdaFunction#grantPush you need a reference to a lambda.IFunction.
3aa03cc
to
125f4b6
Compare
125f4b6
to
d9e571b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30270.
Reason for this change
Lambda Function target is not supported yet by pipes-targets.
Description of changes
LambdaFunctionInvocationType.REQUEST_RESPONSE
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license