-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change estimate_mode default to "ECONOMICAL" in these RPC calls #30009
Comments
Another option would be to have a config for default estimate mode but in that case also the default should be "ECONOMICAL" and not "CONSERVATIVE" |
Unfortunately even "economic" mode still overestimate so changing default mode to "economic" does not fix this issue. There is an ongoing effort "see delving post" where contributors are discussing the challenges of Yes this is a known issue and there is a work in progress to resolve it. |
Maybe it does not fix it all together, but it makes it overestimate less. The difference between ECONOMICAL and CONSERVATIVE for a confirmation target of 2 to 12 blocks is HUGE (by a factor of 7) The CONSERVATIVE mode uses the long stats for the 95% confirmation target, they have a half-time of 1008 blocks! |
Agreed that switching to economical is not a long-term fix for fee estimation, but it's still a notable improvement. Implementing this change would likely lead to a very noticeable reduction in fees paid by Bitcoin Core users, and users of Bitcoin Core fee estimation, and Bitcoin users as a whole. To give an idea of how much this affects a business which does a lot of Bitcoin transaction, we actually created software that will pull the recomended fees from the mempool api and we feed that to Bitcoin Core as feerate instead of using the confirmation target. Not everybody has the technical capacity to do that, switching to economical as default would provide much needed relief without any additional complexity added to the fee estimation algorithm. |
Willing to create a PR for this if desired! |
|
The default fee estimate mode for the following RPC calls is set to "ECONOMICAL" rather than "CONSERVATIVE".
My observation running a Bitcoin non-custodial exchange and payment processor which creates a lot transactions is that Bitcoin Core on conservative mode consistently overpays transaction fees as compared to mempool's fee estimation algorithm. I have collected data on this, if anyone needs convincing, but I think this is common knowledge.
Since RBF, it is standard best practice for advanced Bitcoin users to "lowall" transaction fees instead and RBF later if their transaction. Unfortunately, Bitcoin Core users and wallets which use Bitcoin Core's fee estimation will probably use the default mode (as users always do) and this will lead them to "overpay" more often than not.
Therefore, I suggest changing the default fee estimation mode to "ECONOMICAL" in the following RPCs
estimatesmartfee
send
sendmany
sendtoaddress
fundrawtransaction
Getting Started
walletcreatefundedpsbt
I would exclude this change from RBF related RPCs, where the user probably wants the RBF to be sucessful and is clearly willing to pay more for faster confirmation.
psbtbumpfee
bumpfee
I'm not a developer but am willing to financially support a developer willing to make a PR for this if there is interest.
The text was updated successfully, but these errors were encountered: