Removal of scandir package from requirements-ci.txt #7633
Conversation
|
requirements-ci.txt is used to ensure that the set of installed packages is reproducible in CI. We should ensure that scandir does not come from some transitive dependency. We can remove this package only if there are no such dependencies. |
|
If there was a transitive dependency, then https://buildbot.buildbot.net/#/builders/2/builds/5753 May I ask what should I look for and check? |
pmisik
changed the title
You're right. I removed the transitive dependencies from requirements-ci.txt, installed it and it didn't bring scandir. |
`scandir` has been included in the Python 3.5 standard library as os.scandir(), and the related performance improvements to os.walk() have also been included. see https://github.com/benhoyt/scandir?tab=readme-ov-file#now-included-in-a-python-near-you As Buildbot now requires Python 3.8 or newer we can use standard library rather than package. Fixes buildbot#7632
scandirhas been included in the Python 3.5 standard library as os.scandir(), and the related performance improvements to os.walk() have also been included. see https://github.com/benhoyt/scandir?tab=readme-ov-file#now-included-in-a-python-near-youAs Buildbot now requires Python 3.8 or newer we can use standard library rather than package.
Fixes #7632
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)