Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Code #32581

Closed
boggye opened this issue May 15, 2024 · 0 comments · Fixed by #32627
Closed

Incorrect Code #32581

boggye opened this issue May 15, 2024 · 0 comments · Fixed by #32627
Labels

Comments

@boggye
Copy link

boggye commented May 15, 2024

Description

[Enter feedback here]
The following code is incorrect:

            OriginalPathAndQuery = string.Join(
                statusCodeReExecuteFeature.OriginalPathBase,
                statusCodeReExecuteFeature.OriginalPath,
                statusCodeReExecuteFeature.OriginalQueryString);

It should be:

            OriginalPathAndQuery = string.Join("",
                statusCodeReExecuteFeature.OriginalPathBase,
                statusCodeReExecuteFeature.OriginalPath,
                statusCodeReExecuteFeature.OriginalQueryString);

The first parameter of the Join call is the separator and it is missing.

Also, if I may give you a feedback about the entire page, I found it hard to consume it because there is a lot of disparate information that can apply in different contexts.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/fundamentals/error-handling?view=aspnetcore-8.0#usestatuscodepageswithreexecute

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/fundamentals/error-handling.md

Document ID

38515dfb-91a5-b395-db9d-084bbaf095c8

Article author

@tdykstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants