Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: merged pr #42093 "fix: console.log() in AudioWorkletGlobalScope" does not work as expected #42211

Closed
3 tasks done
appdevopts opened this issue May 16, 2024 · 4 comments
Closed
3 tasks done

Comments

@appdevopts
Copy link

appdevopts commented May 16, 2024

Preflight Checklist

Electron Version

28.3.1

What operating system are you using?

macOS

Operating System Version

Mac OS X 12.7.1

What arch are you using?

x64

Last Known Working Electron version

28.3.1

Expected Behavior

Weekly builds for branch 28-x-y should be done sucessfully!

Actual Behavior

Failed to build each of time after pr #41895 was merged!

Each time of failed build shows error as follows:

TypeScript compilation failed. Used tsconfig gen/third_party/devtools-frontend/src/front_end/core/sdk/sdk-tsconfig.json

../../third_party/devtools-frontend/src/front_end/core/sdk/ChildTargetManager.ts(177,19): error TS2339: Property 'Worklet' does not exist on type 'typeof Type'.

Testcase Gist URL

No response

Additional Information

This is why I have opened this issue #42204 which has already been closed.

@appdevopts
Copy link
Author

https://app.circleci.com/pipelines/github/electron/electron?branch=28-x-y&status=failed

Are there any one familiar with these codes could help to have a look on it?

Branch 28-x-y has already not been built and released about ONE month, which should be done weekly usually!!!

@appdevopts appdevopts changed the title [Bug]: merged pr #42093 "Add support of the Worklet target" is not worked as expected [Bug]: merged pr #42093 "Add support of the Worklet target" does not work as expected May 16, 2024
@appdevopts
Copy link
Author

appdevopts commented May 16, 2024

This pr #42093 (Add support of the Worklet target) looks like trying to resolve this issue, but it seems that it does not work as expect!

https://github.com/electron/electron/pull/42093/files#diff-2c0a59a9393373bfbf3b76c74dd3406528da6e9df8b80a9a2ee52067c0d19c5aR38

@appdevopts appdevopts changed the title [Bug]: merged pr #42093 "Add support of the Worklet target" does not work as expected [Bug]: merged pr #42093 "fix: console.log() in AudioWorkletGlobalScope" does not work as expected May 16, 2024
@appdevopts
Copy link
Author

appdevopts commented May 16, 2024

Why there are two similar folders name for devtools frontend?

https://github.com/electron/electron/tree/28-x-y/patches/devtools-frontend
https://github.com/electron/electron/tree/28-x-y/patches/devtools_frontend

The same folder name in chromium is:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend

So, it seems the "devtools-frontend" should be the correct folder name!

pr #40413 & #41895 import this wrong folder name

@clavin
Copy link
Member

clavin commented May 21, 2024

Fixed in #42212.

@clavin clavin closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants