Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-compiler-healthcheck prints "StrictMode usage not found." in Next.js project with reactStrictMode: true in next.config.js #29130

Closed
wojtekmaj opened this issue May 17, 2024 · 0 comments · Fixed by #29167
Closed

react-compiler-healthcheck prints "StrictMode usage not found." in Next.js project with reactStrictMode: true in next.config.js #29130

wojtekmaj opened this issue May 17, 2024 · 0 comments · Fixed by #29167
Labels
Component: Optimizing Compiler

Comments

@wojtekmaj
Copy link

Summary

Can't provide a sandbox with Next.js I guess, but the case is rather simple. In Next.js, you don't manually add StrictMode, so the checks implemented in compiler/packages/react-compiler-healthcheck/src/checks/strictMode.ts won't apply. On top of these, we should add reactStrictMode: true detection in next.config.js, if the latter file is found.
@josephsavona josephsavona changed the title [React 19] react-compiler-healthcheck prints "StrictMode usage not found." in Next.js project with reactStrictMode: true in next.config.js react-compiler-healthcheck prints "StrictMode usage not found." in Next.js project with reactStrictMode: true in next.config.js May 17, 2024
@abizek abizek mentioned this issue May 19, 2024
Merged
poteto pushed a commit that referenced this issue May 20, 2024
@abizek
feat(compiler-healthcheck): Support strict mode check for nextjs apps (…
d3ce0d3 
…#29167)

## Summary

Closes #29130 

## How did you test this change?

Run the healthcheck in the compiler playground and the nodejs.org repo
for the next config with a `.mjs` extension. Sanity with Vite React
template.

Signed-off-by: abizek <abishekilango@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Optimizing Compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compiler-healthcheck): Support strict mode check for nextjs apps abizek/react
2 participants
@wojtekmaj @josephsavona