-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofill Hints not populating in text fields on iOS with Flutter 3.22.0 #148475
Comments
I've the same problem on iPhone 15 Pro Simulator. When I click on Password button upon the keyboard, autofill not complete, but keyboard disappear and appear magically :D |
Thanks for the update @gonciuu RPReplay-Final1715928118.MP4As shown here, tapping in email address field, it shows Can you use the same example and check at your end to see if it works as expected ? I tried to use your code sample but it contains custom implementation so couldn't use it directly. code sampled used
|
@darshankawar I've tried your code on iPhone 15 Pro Simulator with iOS 17.4, same @gonciuu problem. Now I'm testing it on real device. Stay tuned for updates |
@darshankawar Yes, the bug still occurs, in the example you sent it also doesn't work as expected. After pick the credentials from keychain it should fill the form :P |
Same problem with real device (iPhone 13 mini with iOS 17.4.1). Selecting credentials from saved credentials list fills username and password, but selecting credentials from keyboard hint autofill not happen |
Thanks for the updates @gonciuu and @vitoMacnil RPReplay-Final1715945336.MP4In your case, trying to select the email field or credentials from hint bar doesn't populate the field, is this a correct interpretation of the issue ? Also, please confirm if this you are seeing only in 3.22.0 and used to work in previous version ? |
Yes, that's the correct interpretation. I downloaded an old version of the app from testflight, which was on flutter version 3.19.x and everything work correctly, so I can guess that's the problem with this latest release. |
Thanks for the update. I was unable to replicate this based on my earlier verification, so this seems to be device + OS specific and per OP's comment, this worked in previous version but not working in latest version, so I'll label this as regression for team's attention. |
CONFIRMED!!! It's a bug on latest flutter sdk version. With flutter SDK 3.19.6 version it works. |
I suspect it's caused by #142930. TextFields close their input connection when they lose focus, and autofill requires the target text field (or another text field in the same autofill group) to have an active input connection. |
Nice finding @LongCatIsLooong !! I reverted this patch locally and it fixes the problem 🙌 |
Same error here, the error occurs after upgrade to 3.22.0. I can reproduce the error using my real iOS device. iPhone 15 iOS 17.4 |
Just filed a PR. Thanks @LongCatIsLooong and @xvrh! |
Are there any updates? |
@Pholluxion you can see the current status by going to the pull request linked above. It'll be merged once someone with write access in this repository gives an approval. |
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes #148475
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes flutter#148475
I am going to request this as a hotfix. Can someone confirm this behavior now works on the master channel, as expected, on top of the fix #148612? |
Unfortunately it looks like #148612 was reverted since it caused some web platform testing issues. We should be able to address this within the next few minutes 🙂 |
I've checked this on 3.22.1 and the bug still occurs. @vitoMacnil What about you? |
I checked with (flutter-3.23-candidate.2) And it works ok. Thanks. |
So should I use candidate version, or this fix will be merged soon? |
@gonciuu I believe the plan is to wait for a few days to make sure we don't have any tests failing, and then we'll cherry-pick this patch into an upcoming "stable" release. (I can't make any guarantees though.) |
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes flutter#148475
…#148984) It looks like removing `kIsWeb` from the `FocusManager._appLifecycleListener` platform check is causing [memory leaks](flutter#148985) and test failures. This pull request fixes flutter#148475 and prevents the test failures shown in flutter#148978.
Steps to reproduce
Expected results
Input fields should be automatically populated with relevant data when using autofill on iOS, similar to how it works on Android.
Actual results
Autofill suggestions appear on iOS, but selecting a suggestion does not populate the input fields.
Code sample
Screenshots or Video
RPReplay_Final1715851761.1.mp4
Logs
No response
Flutter Doctor output
[✓] Flutter (Channel stable, 3.22.0, on macOS 14.4.1)
• Flutter version 3.22.0 on channel stable at
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 5dcb86f (7 days ago), 2024-05-09 07:39:20 -0500
• Engine revision f6344b75dc
• Dart version 3.4.0
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK path
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = path
• Java binary at: path
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] Network resources
• All expected network resources are available.
The text was updated successfully, but these errors were encountered: