-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): api/users/get-public-profile #54729
feat(api): api/users/get-public-profile #54729
Conversation
46b56d6
to
9295054
Compare
4278798
to
53c3893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Discussed in meeting: The new api returns is2018FullStackCert
, but the old api does not. Theoretically, this is a bug in the old api.
The body is used for validation and so should care about format, length and so on. In contrast the response should not be validated because it would mix concerns (the handler is under our control and should not produce invalid output).
1ee0083
to
1c51c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over and tested this - everything seems to be working 👍
The new api returns is2018FullStackCert, but the old api does not...
I think this is a cert that we stopped offering. Nobody ever claimed it if it's the one I'm thinking of.
Checklist:
main
branch of freeCodeCamp.Post MVP, it would be nice if this just returned what get-session-user returns, but with the private properties null (or omitted). This would both clean up the code and make it clearer what the privacy toggles control.
Closes #54728