-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExchangeDelistFilter Feature #9985
Comments
in principle - absolutely not against this - as in - would be great to have it. That most likely means that it should be moved into the exchange class - with a flag that can "enable" this functionality from there (so adding new exchanges won't need a new filter). you'll also want to implement some caching (and error-handling) i'd think (also for personal use) - At least on binance, this seems to be pretty far into the future (current delistings happen on april 3rd) - so a caching of "once per hour" might suffice ...? |
The issue with this approach is, for it to be effective, you need to refresh the list frequently. 30 mins is a long time. By the time your code fetch the new delist, it would have been down 30% for example. I'm not sure what is the best number, but 20-30 secs should be ideal. But that leads to the second issue. Rate limit. If you only run 1 bot from 1 IP address, you have no issue. But once you run multiple bots, the weight of them pulling the info every 20-30secs gonna make your IP banned temporarily. We have unofficial binance proxy to fetch candle data through websocket, but it seems the delist announcement isn't available in websocket. Personally, I would create a separate bot to check the delist, and send the list to all bots |
I have it currently running on 60sec on a 5mins timeframe could be enough to have this caught |
Maybe we can implement this also on the dataprovider so we could actually use the call on the the confirm_trade_entry and or custom_trade_exit |
well that's the idea I'd think - yes, absolutely. if we try to implement caching - I'd probably go with a way similar to how we use it in get_rate - where we push the data into an expiring cache - which people can configure the way they desire. the |
Describe the enhancement
Hey Guys I have written a delist filter for binance
https://binance-docs.github.io/apidocs/spot/en/#get-symbols-delist-schedule-for-spot-market_data
Not sure if it makes sense or if it actually will help but maybe you think about this and maybe this worthy to take into the mainline
It requires authentication so it might only run in not dry mode.
The text was updated successfully, but these errors were encountered: