Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: VS Code extension ignores launchOptions.executablePath #30877

Open
hbenl opened this issue May 17, 2024 · 2 comments
Open

[Bug]: VS Code extension ignores launchOptions.executablePath #30877

hbenl opened this issue May 17, 2024 · 2 comments

Comments

@hbenl
Copy link

hbenl commented May 17, 2024

Version

Playwright 1.44.0, VS Code 1.89.1, Extension 1.1.2

Steps to reproduce

  • git clone https://github.com/replayio/devtools
  • cd devtools ; yarn
  • open this folder in VS Code
  • select the replay-chromium playwright project
  • run a test

Expected behavior

The test should run in the Replay Chromium browser.

Actual behavior

The test runs in the version of Chromium installed by playwright instead (when I run ps x I see that it uses .../.cache/ms-playwright/chromium-1117/chrome-linux/chrome)

Additional context

When I run the tests using npx playwright test --project=replay-chromium in the packages/e2e-tests directory, they run in Replay Chromium.

Environment

System:
    OS: Linux 6.5 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    Memory: 18.86 GB / 23.25 GB
    Container: Yes
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 3.2.1 - ~/tmp/devtools/node_modules/.bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
  Languages:
    Bash: 5.1.16 - /usr/bin/bash
@yury-s
Copy link
Member

yury-s commented May 17, 2024

Can you please extract relevant bits into a minimal reproduction, with relevant bits of the browser path resolution in the config?

@mxschmitt
Copy link
Member

I can reproduce, this doesn't work in VSCode while it works in CLI:

  projects: [
    {
      name: 'test1', 
      use: {
        launchOptions: {
          executablePath: '/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge'
        }
      }
    },
  ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants