Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords: Support apostrophes in keywords #4268

Open
annappropriate opened this issue May 19, 2024 · 2 comments
Open

Keywords: Support apostrophes in keywords #4268

annappropriate opened this issue May 19, 2024 · 2 comments
Labels
enhancement Refactoring, improvement or maintenance task help wanted Well suited for external contributors!

Comments

@annappropriate
Copy link

1. What is not working as documented?

Automatic keywords feature seems to be confusing an apostrophe with a word separator. In my case, PhotoPrism is identifying the place as Лук'янівка, but then sets the keywords to лук, янівка

image

image

2. How can we reproduce it?

I'll provide the sample file below, hope you can reproduce by importing it.

3. What behavior do you expect?

Keyword Лук'янівка ends up as a single word.

4. What could be the cause of your problem?

Unusual use of apostrophe in toponyms? :)

5. Can you provide us with example files for testing, error logs, or screenshots?

Here's the photo, let me know if I should email it instead, and/or provide more photos.

20171104_124509

6. Which software versions do you use?

(a) PhotoPrism Architecture & Build Number: AMD64, ARM64, ARMv7,...
AMD64
Build 240420-ef5f14bc4

(b) Database Type & Version: MariaDB, MySQL, SQLite,...

  mariadb:
    image: mariadb:11
    command: mariadbd --innodb-buffer-pool-size=128M --transaction-isolation=READ-COMMITTED --character-set-server=utf8mb4 --collation-server=utf8mb4_unicode_ci --max-connections=512 --innodb-rollback-on-timeout=OFF --innodb-lock-wait-timeout=120

(c) Operating System Types & Versions: Linux, Windows, Android,...
Linux

(d) Browser Types & Versions: Firefox, Chrome, Safari on iPhone,...
Vivaldi

(e) Ad Blockers, Browser Plugins, and/or Firewall Software?
Don't think it's relevant, but let me know if it is

7. On what kind of device is PhotoPrism installed?

Contabo VPS running Debian

(a) Device / Processor Type: Raspberry Pi 4, Intel Core i7-3770, AMD Ryzen 7 3800X,...
Not sure since it's a VPS, but I can check if needed

(b) Physical Memory & Swap Space in GB
8 GB / 0 GB

(c) Storage Type: HDD, SSD, RAID, USB, Network Storage,...
HDD

(d) Anything else that might be helpful to know?
Not sure, I can send lshw output or similar if needed

8. Do you use a Reverse Proxy, Firewall, VPN, or CDN?

Nginx, but I don't have any issues with it.

@annappropriate annappropriate added the bug Something isn't working label May 19, 2024
@graciousgrey
Copy link
Member

Unfortunately apostrophes in keywords are currently not supported. There is a high risk that many incorrect keywords will be generated, e.g. in languages where apostrophes are used differently or if they are used as regular quotation marks. This can also be a problem in combination with SQL databases and HTML, as quotation marks are reserved characters and also have a special meaning.

Before we make any changes, we would need to do a full analysis of the impact on all other languages.

@graciousgrey graciousgrey added enhancement Refactoring, improvement or maintenance task help wanted Well suited for external contributors! and removed bug Something isn't working labels May 20, 2024
@graciousgrey graciousgrey changed the title Keywords detection splits a word with apostrophe into two comma-separated keywords Keywords: Support apostrophes in keywords May 20, 2024
@annappropriate
Copy link
Author

No problem, thanks for checking it out! I don't have a real use case that suffers from this issue, I just noticed it while reviewing the files. It can be worked around by a two-keyword search I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task help wanted Well suited for external contributors!
Projects
None yet
Development

No branches or pull requests

2 participants