-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gulp 5 #11968
Update to gulp 5 #11968
Conversation
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
@jjspace Could you please review? The goal would be to get this in sometime this week to ensure it has some time in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggetz this mostly looks good, just a few small comments.
I also noticed running npm install
complains that install is deprectated. This is from husky install
being deprecated. It was replaced just by husky
, can you change that in the prepare
script?
Thanks @jjspace! All your feedback should now be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now thanks @ggetz
Description
Update to gulp 5.
This is opened as a draft because, while tasks are running, there's still problems. Right now, mainly with the tests.
stream-to-promise
in favor of the nativefinished
merge-stream
, which does not appear to be maintained. The functionality can be replicated with the gulp API anyway.encoding: false
whenever sourcing images or other binary filesIssue number and link
Fixes #10919
Testing plan
make-zip
,build-apps
, andstart
task worktest
andtest-release
passAuthor checklist
CONTRIBUTORS.md
I have updatedCHANGES.md
with a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have update the inline documentation, and included code examples where relevant