Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: replace selection filter icon with no filter icon #14097

Merged
merged 1 commit into from
May 27, 2024

Conversation

maxwxyz
Copy link
Collaborator

@maxwxyz maxwxyz commented May 17, 2024

Getting rid of the filter icon which is only visible before clicking on the group. Replaces the filter icon with the clear-selection icon which is used for no active selection filter - which is the default state anyways.

Currently:
grafik

This PR:
grafik

@FreeCAD/design-working-group FYI

@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Related to the Part Workbench labels May 17, 2024
@obelisk79
Copy link
Contributor

I agree that this is a logical change.

@FEA-eng
Copy link
Contributor

FEA-eng commented May 20, 2024

Nice, I like this change.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 20, 2024

@FEA-eng stop commenting on my PRs on Mondays 😄 You move them back to the bottom of the list for merging. Every week the same 🤣

@FEA-eng
Copy link
Contributor

FEA-eng commented May 20, 2024

@maxwxyz I’m not commenting just your PRs. On Mondays, I have some time to look at the open PRs before the meeting - test them (5th compilation running now), ask for changes or approve them. Of course, I’m just a regular user, not a maintainer but the first question for each PR during the merge meeting is whether someone tested it or accepted the changes. This one is also quite important for me because the selection filters were implemented on my request. Besides, the PR was far in the queue and it will be merged sooner or later anyway despite the upcoming freeze.

And finally, I comment only if it makes sense (because there are conflicts, a reminder is needed, I want to clarify or change something and so on) to avoid unnecessarily changing the queue.

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented May 20, 2024

@FEA-eng yes, no worries, just joking

@FEA-eng
Copy link
Contributor

FEA-eng commented May 20, 2024

@FEA-eng yes, no worries, just joking

I’m just a fan of your UI/icon improvements ;-) Seriously, you are doing awesome work with that.

@chennes chennes merged commit 6074bcf into FreeCAD:main May 27, 2024
9 checks passed
@maxwxyz maxwxyz deleted the selection-filter-group branch May 27, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB Part Related to the Part Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants