-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: folder inheritance scripts #7430
base: develop
Are you sure you want to change the base?
Conversation
56ee1a1
to
1f2a87e
Compare
0a8579d
to
cabfe9e
Compare
@@ -18,7 +18,7 @@ interface BaseRequestGroup { | |||
environmentPropertyOrder: Record<string, any> | null; | |||
metaSortKey: number; | |||
preRequestScript: string; | |||
postRequestScript: string; | |||
afterRequestScript: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might named it as afterResponseScript
after merging.
title={ | ||
<div className='flex items-center gap-2'> | ||
After-request Script{' '} | ||
{activeRequestGroup.preRequestScript && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be activeRequestGroup.afterResponseScript
instead preXX
.
} | ||
await fn${i}(); | ||
`); | ||
const joinedScript = [...folderScripts].join('\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might also think about things like displaying progress or proper timeout value for joined scripts.
todo
closes INS-3860
challenges