-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selection issue in table row while editing #9725
Conversation
69de198
to
36584a1
Compare
Deployment: https://tooljet-pr-9725.onrender.com |
36584a1
to
5306ae8
Compare
5306ae8
to
eb262ed
Compare
Selecto hijacks the selection event of browser by overriding it, which was preventing selection within a table cell.
the drag condition prop allows us to control selecto's behaviour, now selecto only works if a user starts selecting from outside of a container and not within it(Which allows us to select table cell). In order to allow selection of container when it is clicked, we manually select the container by setSelectedComponent instead of letting selecto select it. |
1.8 merge #9944 |
Fixes 9505