Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update zone-pollution.md #55876

Closed
wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

Provide a thorough explanation of why third-party libraries should be created outside of the Angular zone. Using a statement like "authored with Zone.js in mind" may seem unusual because third-party libraries typically do not have knowledge of Zone.js, nor should they be developed with it in mind. Therefore, we revise this explanation accordingly. Additionally, include a section on handling events originating from third-party APIs.

Provide a thorough explanation of why third-party libraries should be created outside
of the Angular zone. Using a statement like "authored with Zone.js in mind" may seem
unusual because third-party libraries typically do not have knowledge of Zone.js, nor
should they be developed with it in mind. Therefore, we revise this explanation accordingly.
Additionally, include a section on handling events originating from third-party APIs.
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 19, 2024
@ngbot ngbot bot added this to the Backlog milestone May 19, 2024
@arturovt arturovt marked this pull request as ready for review May 19, 2024 16:17
@pullapprove pullapprove bot requested a review from thePunderWoman May 19, 2024 16:17
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release area: adev Angular.dev documentation action: merge The PR is ready for merge by the caretaker and removed area: docs Related to the documentation labels May 20, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit 39feceb.

@dylhunn dylhunn closed this in 39feceb May 21, 2024
dylhunn pushed a commit that referenced this pull request May 21, 2024
Provide a thorough explanation of why third-party libraries should be created outside
of the Angular zone. Using a statement like "authored with Zone.js in mind" may seem
unusual because third-party libraries typically do not have knowledge of Zone.js, nor
should they be developed with it in mind. Therefore, we revise this explanation accordingly.
Additionally, include a section on handling events originating from third-party APIs.

PR Close #55876
dylhunn pushed a commit that referenced this pull request May 21, 2024
Provide a thorough explanation of why third-party libraries should be created outside
of the Angular zone. Using a statement like "authored with Zone.js in mind" may seem
unusual because third-party libraries typically do not have knowledge of Zone.js, nor
should they be developed with it in mind. Therefore, we revise this explanation accordingly.
Additionally, include a section on handling events originating from third-party APIs.

PR Close #55876
@arturovt arturovt deleted the docs/zone-pollution branch May 21, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: adev Angular.dev documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants