Add doas support to is_root_or_sudo_prefix
#6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpardini
requested changes
May 20, 2024
JohnTheCoolingFan
force-pushed
the
doas-support
branch
from
bb4e1cc
to
98390ef
Compare
doas is not compatible with sudo flags. The codebase was checked for sudo-specific uses of this function, but none were found, all cases were in the form of `sudo <command>`. Replacing it with `doas <command>` yields the same result.
JohnTheCoolingFan
force-pushed
the
doas-support
branch
from
98390ef
to
216416d
Compare
igorpecovnik
approved these changes
May 21, 2024
igorpecovnik
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
doas is not compatible with sudo flags. The codebase was checked for sudo-specific uses of this function, but none were found, all cases were in the form of
sudo <command>. Replacing it withdoas <command>yields the same result.Was extracted from #6576 and can't be merged until it's reverted in #6642
How Has This Been Tested?
Used to build images on my machine with extensions that use
is_root_or_sudo_prefixChecklist: