-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #13061: Update grammar for @exception, @throws, and @param tags #14803
base: master
Are you sure you want to change the base?
Conversation
GitHub, generate report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Report is good.
Some maintainer need to create PR from same code to pass all CIs. We can do this before merge.
Minor
...eckstyle/checks/javadoc/nonemptyatclausedescription/InputNonEmptyAtclauseDescriptionTwo.java
Outdated
Show resolved
Hide resolved
d052b98
to
c341c2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
@nrmancuso @rnveach ping |
@0xbakry I am not assigned. Usually we ask for antlr regression on these type of changes, so I would probably be asking for something like that if we can. |
Agree, @0xbakry please do this. See https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#antlr-regression-report for details. |
@0xbakry, please find time to finish PR. It will be good if you send request to Circleci to fix some blockage of your PRs in execution |
Solves #13061
CLI:
config.xml
@param tag:
@exception tag
@throws tag
Now we don't have parser errors.
Diff Regression projects: https://gist.githubusercontent.com/0xbakry/7853843aa3d69aee301d7a8d62d08ebb/raw/65a7d6bee0ad8ad789c17f778ce7d8b0056ae28b/my_projects
Diff Regression config: https://gist.githubusercontent.com/0xbakry/a1fcb13eef42f29de8ff500892f34166/raw/beceb87d12215501a53ffc29e87f6c0af78f588c/config_check.xml