chore: force import assertion support #23855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @petamoriken |
mmastrac
approved these changes
May 17, 2024
petamoriken
reviewed
May 17, 2024
| @@ -405,7 +405,10 @@ fn resolve_flags_and_init( | |||
| // TODO(petamoriken): Need to check TypeScript `assert` keywords in deno_ast | |||
| vec!["--no-harmony-import-assertions".to_string()] | |||
There was a problem hiding this comment.
It seems that this flag is no longer needed.
There was a problem hiding this comment.
Let's leave it for now as the TODOs here seem important. We might need to support import assertions in deno_ast for some more time.
bartlomieju
added a commit
that referenced
this pull request
May 21, 2024
#23838 might accidentally disable import assertions support because of V8 12.6 unshipping it, but we want import assertions to be supported until Deno 2.
bartlomieju
added a commit
that referenced
this pull request
May 21, 2024
#23838 might accidentally disable import assertions support because of V8 12.6 unshipping it, but we want import assertions to be supported until Deno 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23838 might accidentally disable
import assertions support because of V8 12.6 unshipping it, but we want
import assertions to be supported until Deno 2.