[Feature]:Improving GitHub Actions: Preventing Improper Overwrites of Commit Messages #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages When using open commit in GitHub Actions, there is an issue where it overwrites even if there is already a precisely written commit message. Therefore, we have made it possible to set conditions for commit messages that should not be overwritten improperly (such as being abnormally short).
|
how does it overwrite commit messages that were already improved? i remember writing code that improves only new commit message, it shouldn't touch already improved messages. i think we can come up with a better implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using open commit in GitHub Actions, there is a problem that commit messages can be overwritten even if they are already correctly written.
So, we've added a new feature that allows you to set conditions for commit messages that should not be overwritten inappropriately (e.g., unusually short).
Added the ability to define illegal commit messages with regular expressions.
This logic works only with GitHub Actions.
The default condition is to use open comit only for very short commit messages as follows
OCO_INVALID_COMMIT_TITLE_REGEX: ^. {0,5}
OCO_INVALID_COMMIT_DESCRIPTION_REGEX: ^. {0,5}