chore(wasm): add cmake to sdk #3057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kostasrim
commented
May 17, 2024
kostasrim
commented
- add cmake to sdk
dranikpg
approved these changes
May 17, 2024
Comment on lines
+11
to
+17
| The library is header only and exported as an interface. If you want to compile | ||
| the `examples` to wasm you need to export the `CXX` env to point to the `wask-sdk` | ||
| clang variant. Then just follow the simple chore: | ||
|
|
||
| ``` | ||
| mkdir build && cd build && cmake .. | ||
| make -j8 |
There was a problem hiding this comment.
Please add an example how to export CXX to point? Just set env var?
dranikpg
reviewed
May 17, 2024
Comment on lines
+1
to
+9
| project(DragonflyCPPWasmSDK) | ||
|
|
||
| cmake_minimum_required(VERSION 3.20) | ||
|
|
||
| add_library(df-cpp-wasm-sdk INTERFACE) | ||
| target_include_directories(df-cpp-wasm-sdk INTERFACE ${PROJECT_SOURCE_DIR}/include) | ||
|
|
||
| add_executable(example examples/example.cc) | ||
| target_link_libraries(example df-cpp-wasm-sdk) |
There was a problem hiding this comment.
also please make it require c++ 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.