-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CI upgrade to Node 22 #10119
Draft
slorber
wants to merge
6
commits into
main
Choose a base branch
from
slorber/bump-node-22-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: CI upgrade to Node 22 #10119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: internal
This PR does not touch production code, or is not meaningful enough to be in the changelog.
label
May 9, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
JhonySpark
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: internal
This PR does not touch production code, or is not meaningful enough to be in the changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI should use Node 20/LTS by default
Matrix strategies should use Node versions 18.0, 20, 22
Note Node v22 behavior regarding
Intl.DisplayNames
is more "strict" than v18/20 (throws more often). I had to adjust the code accordingly. Not sure if it's a bug or if they follow the spec more accurately.Note TSC has a segmentation fault under Node 22. Apparently, this is related to a V8 maglev bug:
Upgrading to TS 5.5 beta seems to fix it, but our website's main bundle size seems to increases for unexpected reasons. For that reason, I'm going to wait for a stable release.