Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify CC/CXX environment variables during Linux build #148518

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bc-lee
Copy link

@bc-lee bc-lee commented May 16, 2024

This commit enables flutter uses to specify CC and CXX environment variables during the build process for Linux. Also, it warns the user if the provided C or C++ compilers are not the system's clang and clang++ compilers. If these variables are not declared, the program uses the system default compilers.

Closes #104989

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This commit enables flutter uses to specify CC and CXX
environment variables during the build process for Linux. Also, it
warns the user if the provided C or C++ compilers are not the system's
clang and clang++ compilers. If these variables are not declared, the
program uses the system default compilers.

Closes flutter#104989
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels May 16, 2024
@bc-lee bc-lee marked this pull request as draft May 16, 2024 22:46
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Support $CXX environment variable
1 participant