Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ES2024 types, target and fix ES5, ES2017, ES2022 types #58573

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented May 19, 2024

Fixes #54636
Refs #54637, #57858

This PR includes the following changes:

  • Fix ArrayBuffer.prototype.slice types in ES5
  • Fix SharedArrayBuffer.prototype.slice types in ES2017
  • Add empty ArrayBuffer/SharedArrayBuffer types to ES2017
  • BREAKING: Move Atomics.waitAsync types from ES2022 to ES2024
  • Add Resizable/Transfer ArrayBuffer types to ES2024
  • Move some ESNext types to ES2024
  • Introduce ES2024 target

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 19, 2024
@petamoriken petamoriken changed the title fix(dts): Update ES2017 and ES2024 types fix(dts): Update ES5, ES2017 and ES2024 types May 19, 2024
@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@petamoriken petamoriken changed the title fix(dts): Update ES5, ES2017 and ES2024 types Fix ES5, ES2017 types and introduce ES2024 types and target May 19, 2024
@petamoriken
Copy link
Contributor Author

It is strange that ES2024 Atomics.waitAsync is defined in es2022.sharedmemory.d.ts, but probably cannot be fixed.

@petamoriken petamoriken changed the title Fix ES5, ES2017 types and introduce ES2024 types and target Introduce ES2024 types, target and fix ES5, ES2017 types May 20, 2024
@jakebailey
Copy link
Member

If it was a mistake, I don't think we'd be against fixing it. If you make that change, we can run the extended tests and see how bad it would be.

@petamoriken petamoriken changed the title Introduce ES2024 types, target and fix ES5, ES2017 types Introduce ES2024 types, target and fix ES5, ES2017, ES2022 types May 26, 2024
@Manue1137
Copy link

Correcciones #54636 Refs #54637 , #57858

Este Pre incluye los siguientes cambios:

  • Tipos de arreglos ArrayBuffer.prototype.sliceen Este
  • Tipos de arreglos SharedArrayBuffer.prototype.sliceen ES2017
  • Agregar tipos Arra Buffer/ vacíos Separadora ES2017
  • ÚLTIMA HORA : Mover Atomics.waitAsynctipos de ES2022 a ES2024
  • Agregue tipos de Arrancar redimensionables/de transferencia a ES2024
  • Mover algunos tipos de Es Ext a ES2024
  • Introducir el objetivo ES2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(dts): Update type of ArrayBuffer
5 participants