Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds all three package manager commands on js introduction page #30884

Merged
merged 2 commits into from
May 20, 2024

Conversation

atmnk
Copy link
Contributor

@atmnk atmnk commented May 17, 2024

adds all three package manager commands on introduction page namley npm yarn and pnpm at all places earlier only npx and npm command were present Fixes #30012

adds all three package manager commands on introduction page namley npm yarn and pnpm at all places earlier only npx and npm command were present
Fixes microsoft#30012
@atmnk
Copy link
Contributor Author

atmnk commented May 17, 2024

@microsoft-github-policy-service agree

<TabItem value="yarn">

```bash
yarn run playwright test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets align with create-playwright?

yarn playwright and pnpm exec playwright.

https://github.com/microsoft/create-playwright/blob/d278d04bb8d2e45a88e973f39ce6a2b3126da7c3/src/packageManager.ts#L65

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed pushed the fix.

…right

aligns package manager installation commands with create playwright
Fixes microsoft#30012
@atmnk atmnk requested a review from mxschmitt May 18, 2024 07:43
@mxschmitt mxschmitt merged commit 7fd3539 into microsoft:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Please add executing methods using yarn instead of npx
2 participants