Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fixed class name from 'height-auto' to 'h-auto' #2999

Closed
wants to merge 2 commits into from

Conversation

Leosouthey
Copy link

@Leosouthey Leosouthey commented May 14, 2024

📝 Description

Fixed class name from 'height-auto' to 'h-auto'

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

  • Bug Fixes
    • Corrected CSS class name from height-auto to h-auto for better compatibility and styling consistency.

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: caa09bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@nextui-org/system-rsc Patch
@nextui-org/theme Patch
@nextui-org/code Patch
@nextui-org/divider Patch
@nextui-org/kbd Patch
@nextui-org/spacer Patch
@nextui-org/spinner Patch
@nextui-org/system Patch
@nextui-org/accordion Patch
@nextui-org/autocomplete Patch
@nextui-org/button Patch
@nextui-org/calendar Patch
@nextui-org/date-picker Patch
@nextui-org/dropdown Patch
@nextui-org/listbox Patch
@nextui-org/menu Patch
@nextui-org/modal Patch
@nextui-org/navbar Patch
@nextui-org/popover Patch
@nextui-org/select Patch
@nextui-org/slider Patch
@nextui-org/snippet Patch
@nextui-org/table Patch
@nextui-org/tabs Patch
@nextui-org/tooltip Patch
@nextui-org/react Patch
@nextui-org/aria-utils Patch
@nextui-org/framer-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:18am

Copy link

vercel bot commented May 14, 2024

@Leosouthey is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The recent changes involve updating a class name from "height-auto" to "h-auto" across the @nextui-org/system-rsc and @nextui-org/theme packages. This modification ensures consistency and potentially aligns with a new naming convention for CSS classes. The updates affect the slots-component.tsx file in the system-rsc package and the card.ts file in the theme package.

Changes

Files Change Summary
packages/core/system-rsc/test-utils/slots-component.tsx Replaced "height-auto" with "h-auto" in class names.
packages/core/theme/src/components/card.ts Updated class name from "height-auto" to "h-auto".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8988981 and caa09bb.
Files selected for processing (3)
  • .changeset/nervous-experts-cough.md (1 hunks)
  • packages/core/system-rsc/test-utils/slots-component.tsx (1 hunks)
  • packages/core/theme/src/components/card.ts (1 hunks)
Files skipped from review due to trivial changes (3)
  • .changeset/nervous-experts-cough.md
  • packages/core/system-rsc/test-utils/slots-component.tsx
  • packages/core/theme/src/components/card.ts

@wingkwong wingkwong added this to the v2.3.7 milestone May 15, 2024
@wingkwong
Copy link
Member

No longer applicable.

@wingkwong wingkwong closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants