Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix t.assert methods #53049

Merged
merged 4 commits into from
May 20, 2024
Merged

test_runner: fix t.assert methods #53049

merged 4 commits into from
May 20, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 18, 2024

The node:assert module contains several top level APIs that do not make sense to expose as methods on t.assert. Examples include AssertionError and CallTracker. This commit removes such APIs from t.assert.

This appears to have been lost in translation from cjihrig@89d9a7e to #52860.

Refs: #52860

@cjihrig
test_runner: fix t.assert methods
833d98f 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: nodejs#52860
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner labels May 18, 2024
@cjihrig cjihrig requested review from MoLow and atlowChemi May 18, 2024 16:40
aduh95
aduh95 reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to write the code in a way that is not affected by prototype mutation, you'd need to move some things around

lib/internal/test_runner/test.js Show resolved Hide resolved
lib/internal/test_runner/test.js Outdated Show resolved Hide resolved
cjihrig and others added 2 commits May 18, 2024 20:59
@cjihrig @aduh95
Update lib/internal/test_runner/test.js
59a6d7b 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@cjihrig @aduh95
Update lib/internal/test_runner/test.js
3f68770 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented May 19, 2024

@aduh95 I have committed your suggestions directly. PTAL

@cjihrig cjihrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 19, 2024
MoLow
MoLow approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lint needs fixing

@cjihrig @aduh95
Update lib/internal/test_runner/test.js
f3efcf9 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59309/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2024
@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit f9a0913 into nodejs:main May 20, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f9a0913

@cjihrig cjihrig deleted the fix-assert branch May 20, 2024 17:15
targos pushed a commit that referenced this pull request May 21, 2024
@cjihrig @targos
test_runner: fix t.assert methods
3ff174f 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: #52860
PR-URL: #53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@cjihrig @lukins-cz
test_runner: fix t.assert methods
45d32fb 
The node:assert module contains several top level APIs that do
not make sense to expose as methods on t.assert. Examples include
AssertionError and CallTracker. This commit removes such APIs from
t.assert.

Refs: nodejs#52860
PR-URL: nodejs#53049
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cjihrig @nodejs-github-bot @benjamingr @MoLow @aduh95 @atlowChemi