feat(api): add enable type validation #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
commented
May 20, 2024
There was a problem hiding this comment.
added missing validation on our dto.
djabarovgeorge
commented
May 20, 2024
| @@ -31,7 +31,7 @@ describe('Update Subscribers preferences - /subscribers/:subscriberId/preference | |||
|
|
|||
| try { | |||
| const response = await updatePreference(updateDataEmailFalse as any, session, template._id); | |||
| expect(response).to.not.be; | |||
There was a problem hiding this comment.
we were missing the 'ok' in order test in order to trigger failure if the test is falsely passed.
djabarovgeorge
commented
May 20, 2024
| @@ -9,6 +10,8 @@ export class UpdateSubscriberPreferenceRequestDto { | |||
| description: 'The subscriber preferences for every ChannelTypeEnum for the workflow assigned.', | |||
| }) | |||
| @ValidateNested() | |||
| @Type(() => ChannelPreference) | |||
There was a problem hiding this comment.
needed in order to execute @ValidateNested()
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…-value-type-string-at-path
djabarovgeorge
deleted the
nv-3827-casterror-cast-to-boolean-failed-for-value-type-string-at-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fix - CastError: Cast to Boolean failed for value "" (type string) at path "channels.sms" because of "CastError"
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer