fix(node): Enable e2e test #23508
Open
fix(node): Enable e2e test #23508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 261ec16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
fix/node-e2e-test
branch
2 times, most recently
from
be7fcdc
to
419e05c
Compare
ndcunningham
added
the
scope: node
ndcunningham
force-pushed
the
fix/node-e2e-test
branch
from
419e05c
to
d80fd07
Compare
FrozenPandaz
requested changes
May 21, 2024
ndcunningham
force-pushed
the
fix/node-e2e-test
branch
from
d80fd07
to
72421e3
Compare
ndcunningham
force-pushed
the
fix/node-e2e-test
branch
from
72421e3
to
885f723
Compare
FrozenPandaz
requested changes
May 24, 2024
| @@ -30,15 +28,16 @@ function normalizeOptions( | |||
| } | |||
|
|
|||
| function addDocker(tree: Tree, options: SetUpDockerOptions) { | |||
| // Inferred targets are only available in the project graph | |||
| const projectConfig = readCachedProjectConfiguration(options.project); | |||
| const projectConfig = readProjectConfiguration(tree, options.project); | |||
There was a problem hiding this comment.
This won't include inferred targets...
Shouldn't we still be able to setup docker for projects with inferred build targets?
There was a problem hiding this comment.
Why not?
- If the project has not been created yet, reading from the graph would be invalid right?
- The
treeis passed in as an argument, which is probably the source of truth for generators.
The current setup should work for both crystal and non-inferred projects.
ndcunningham
force-pushed
the
fix/node-e2e-test
branch
from
885f723
to
261ec16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables e2e tests for node