libobs: Fix missing started signal upon second start of delayed output #10653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an output has delay enabled and is gracefully stopped once, upon startup a second time, it will not send the
started
signal. This is due toobs_output_signal_stop()
pre-emtively settingdelay_active
to false. It is later set tofalse
inobs_output_end_data_capture_internal()
, so this logic is not needed anyway.When the encoder is then started a second time,
output->delay_capturing
will still be true, resulting inbegin_delayed_capture()
returning early and not firing thestarted
signal.Motivation and Context
I was testing other changes and measuring the various signals of outputs, and noticed that when I performed the reproduction steps above, I wasn't getting a
started
signal.How Has This Been Tested?
Ubuntu 22.04
WHIP output
Tested every combination of:
Repro steps:
starting
then astarted
eventstarting
event but nostarted
eventTypes of changes
Checklist: