Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Removed unused friend classes #10684

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Tunghohin
Copy link
Contributor

Description

The class DeviceToolbarPropertiesThread appears to have been removed, and the friend class here is redundant code

Motivation and Context

The class is located in
屏幕截图 2024-05-17 163702
but has been removed in 50d3130.
屏幕截图 2024-05-17 163637

How Has This Been Tested?

Yes, on windows11-22H2.

Types of changes

Clean up code.

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label May 17, 2024
@norihiro
Copy link
Contributor

Another class TwitchLogin is not found as well. Can we remove it at the same time?

friend class TwitchLogin;

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use merge commits to catch up on commit history. Use git rebase.

@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 28, 2024
@RytoEX RytoEX changed the title UI: Removed unused friend class UI: Removed unused friend classes May 28, 2024
@RytoEX RytoEX merged commit 51fd7fb into obsproject:master May 28, 2024
15 checks passed
@Tunghohin Tunghohin deleted the cleanup branch May 29, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants