-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-3775: add tests for CMO collection profiles #28768
base: master
Are you sure you want to change the base?
Conversation
@rexagod: This pull request references MON-3775 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rexagod: This pull request references MON-3775 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Job Failure Risk Analysis for sha: e449b02
|
Job Failure Risk Analysis for sha: a0a9fc1
|
97d386a
to
62cbbbb
Compare
Job Failure Risk Analysis for sha: 62cbbbb
|
Job Failure Risk Analysis for sha: 060391d
|
/pj-rehearse periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-techpreview |
/test e2e-gcp-ovn-techpreview |
Refer: openshift/enhancements#1298 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
/hold cancel |
Ah, it seems origin/pkg/defaultmonitortests/types.go Line 58 in a91b2bf
|
) | ||
|
||
const ( | ||
testName = "[sig-instrumentation][OCPFeatureGate:MetricsCollectionProfiles] Monitoring collection profiles have all service monitor counterparts present" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nomenclature inferred from https://github.com/deads2k/api/blob/master/README.md#defining-featuregate-e2e-tests.
6ceec57
to
2b6dd3b
Compare
/test e2e-gcp-ovn-techpreview |
@rexagod: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 2b6dd3b
|
The tests cover the following cases:
ServiceMonitor
s are available.is checked within the CMO tests itself.
*monitor
selectors' reconciliation after a collectionprofile is applied is checked within the CMO tests itself.
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava rexagod@gmail.com