Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable possibly-used-before-assignment and fix a few of them #9652

Merged
merged 3 commits into from
May 20, 2024

Conversation

aatle
Copy link
Contributor

@aatle aatle commented May 18, 2024

Type of Changes

Type
🔨 Refactoring

Description

Original: #9644

Enables possibly-used-before-assignment for the pylint codebase, fixes the errors in two files, and locally disables the rest.
The disabled errors can probably be fixed but would need extra code coverage.

Refs #9637

@jacobtylerwalls jacobtylerwalls added Skip news 🔇 This change does not require a changelog entry Maintenance Discussion or action around maintaining pylint or the dev workflow labels May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (978981d) to head (cfde1e5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9652      +/-   ##
==========================================
- Coverage   95.86%   95.86%   -0.01%     
==========================================
  Files         174      174              
  Lines       18907    18896      -11     
==========================================
- Hits        18125    18114      -11     
  Misses        782      782              
Files Coverage Δ
pylint/checkers/__init__.py 93.10% <ø> (ø)
...heckers/refactoring/implicit_booleaness_checker.py 100.00% <100.00%> (ø)
pylint/checkers/similar.py 96.23% <100.00%> (-0.06%) ⬇️
pylint/checkers/typecheck.py 96.62% <ø> (ø)
pylint/testutils/_primer/primer.py 96.15% <ø> (ø)

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit cfde1e5

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup, congratulation on becoming a pylint contributor :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 23c6d37 into pylint-dev:main May 20, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants