[bazel] upgrade cython package #45436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
seems that I need to stick with 0.29.x |
aslonnie
force-pushed
the
lonnie-240519-cythonup
branch
from
d647680
to
eb8b608
Compare
aslonnie
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha,
simonsays1980,
ericl,
architkulkarni,
hongchaodeng and
a team
as code owners
to latest release 3.0.10 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-240519-cythonup
branch
from
b98d466
to
301e723
Compare
aslonnie
commented
May 20, 2024
| @@ -183,7 +183,7 @@ | |||
| subprocess.run( | |||
| "sudo apt-get install -y build-essential curl unzip psmisc".split(" ") | |||
| ) | |||
| subprocess.run("pip install cython==0.29.26 pytest".split(" ")) | |||
| subprocess.run("pip install cython==0.29.37 pytest".split(" ")) | |||
There was a problem hiding this comment.
@sven1977 , do the rllib people still use this bisect tool?
fwiw, we have repo wide bisect tool now.
|
ping for review. |
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
ok I am merging. @sven1977 (or any one else), if you need to revert this or some files in this, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to 0.29.37; required for bazel upgrade.