Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(direnv): replace nonexistent "orange" color with "bright-yellow" #5969

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

DerRockWolf
Copy link
Contributor

Description

bold orange doesn't exist in predefined_color and the module text was therefore just white.

How Has This Been Tested?

  • I have tested using Linux

By manually adjusting my config to be `style = 'bold bright-yellow'.

Checklist:

  • I have updated the documentation accordingly.
    • Can I directly update the default in all translations?

@davidkna
Copy link
Member

Please also update the test to work with the new styling.

@DerRockWolf
Copy link
Contributor Author

Fixed!
Hopefully I did it correctly. 🤞 First time developing in rust.

@davidkna davidkna changed the title Fix direnv config: change style from nonexistent "bold orange" to "bold bright-yellow" fix(sirens): replace nonexistent "orange" color with "bright-yellow" May 15, 2024
@davidkna davidkna changed the title fix(sirens): replace nonexistent "orange" color with "bright-yellow" fix(direnv): replace nonexistent "orange" color with "bright-yellow" May 15, 2024
@andytom andytom merged commit 478d5cc into starship:master Jun 2, 2024
21 checks passed
@andytom
Copy link
Member

andytom commented Jun 2, 2024

Thank you for your contribution @DerRockWolf and thanks for reviewing @davidkna.

@DerRockWolf DerRockWolf deleted the fix/direnv branch June 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants